[ovs-dev] [PATCH] acinclude: Silence OVS_FIND_FIELD_IFELSE.

[Joe Stringer]

On 20 July 2015 at 10:51, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Jul 20, 2015 at 10:12:31AM -0700, Joe Stringer wrote:
>> On 17 July 2015 at 12:58, Ben Pfaff <blp at nicira.com> wrote:
>> > On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote:
>> >> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>> >> ---
>> >>  acinclude.m4 | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/acinclude.m4 b/acinclude.m4
>> >> index 14907ab..4f1e66c 100644
>> >> --- a/acinclude.m4
>> >> +++ b/acinclude.m4
>> >> @@ -271,7 +271,7 @@ dnl translated to uppercase.
>> >>  AC_DEFUN([OVS_FIND_FIELD_IFELSE], [
>> >>    AC_MSG_CHECKING([whether $2 has member $3 in $1])
>> >>    if test -f $1; then
>> >> -    awk '/$2.{/,/^}/' $1 2>/dev/null | grep '$3'
>> >> +    awk '/$2.{/,/^}/' $1 2>/dev/null | grep -q '$3'
>> >
>> > The autoconf manual recommends avoiding -q, so can we redirect to
>> > /dev/null instead?
>>
>> Sure thing. This incremental retains the fix:
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index 4f1e66c..3604e55 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -271,7 +271,7 @@ dnl translated to uppercase.
>>  AC_DEFUN([OVS_FIND_FIELD_IFELSE], [
>>    AC_MSG_CHECKING([whether $2 has member $3 in $1])
>>    if test -f $1; then
>> -    awk '/$2.{/,/^}/' $1 2>/dev/null | grep -q '$3'
>> +    awk '/$2.{/,/^}/' $1 2>/dev/null | grep '$3' >/dev/null
>>      status=$?
>>      case $status in
>>        0)
>
> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks, applied to master and branch-2.4.