[ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

[Alex Wang]

Sorry for the unclarity, I'm building branch-2.4.

Master is fine,

Thanks,
Alex Wang,

On Mon, Jul 20, 2015 at 12:11 PM, Kyle Upton <kupton at baymicrosystems.com>
wrote:

> Without the change, I see the following while doing a build in our
> modified version of ovs. The input source file is lib/ofp-errors.c instead
> of ../lib/ofp-errors.c.  Same thing occurs with ofp-msgs.c.  With the
> change, I don't see this issue and my thinking was that the object and not
> the source depends on the include file.  I had done a merge with the most
> recent upstream (commit SHA 4249b54) when the problem occurred.  Build is
> done on Ubuntu 14.04.  I'm also able to do a build following
> INSTALL.Debian.md with the latest vanilla OVS from today that includes
> the change (commit SHA 38876d3):
>
> PYTHONPATH=../python":"$PYTHONPATH PYTHONDONTWRITEBYTECODE=yes
> /usr/bin/python ../build-aux/extract-ofp-errors \
>                 ../lib/ofp-errors.h \
>                 ../include/openflow/openflow-common.h >
> lib/ofp-errors.inc.tmp && \
>         mv lib/ofp-errors.inc.tmp lib/ofp-errors.inc
> depbase=`echo lib/ofp-errors.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
>         /bin/bash ./libtool  --tag=CC   --mode=compile gcc -std=gnu99
> -DHAVE_CONFIG_H -I. -I..   -DBAY -DIBEX2  -I ../include -I ./include -I
> ../lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
> -Wpointer-arith -Wformat-security -Wswitch-enum -Wunused-parameter
> -Wbad-function-cast -Wcast-align -Wmissing-prototypes
> -Wmissing-field-initializers -fno-strict-aliasing -fPIC   -g -O0
> -fstack-protector --param=ssp-buffer-size=4 -Wformat
> -Werror=format-security -MT lib/ofp-errors.lo -MD -MP -MF $depbase.Tpo -c
> -o lib/ofp-errors.lo lib/ofp-errors.c &&\
>         mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -DBAY -DIBEX2
> -I ../include -I ./include -I ../lib -I ./lib -Wstrict-prototypes -Wall
> -Wextra -Wno-sign-compare -Wpointer-arith -Wformat-security -Wswitch-enum
> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wmissing-prototypes
> -Wmissing-field-initializers -fno-strict-aliasing -fPIC -g -O0
> -fstack-protector --param=ssp-buffer-size=4 -Wformat
> -Werror=format-security -MT lib/ofp-errors.lo -MD -MP -MF
> lib/.deps/ofp-errors.Tpo -c lib/ofp-errors.c -o lib/ofp-errors.o
> gcc: error: lib/ofp-errors.c: No such file or directory
> gcc: fatal error: no input files
> compilation terminated.
> make[4]: *** [lib/ofp-errors.lo] Error 1
> make[4]: Leaving directory `/home/kyle/baygit/openvswitch.new/ovs/_debian'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/home/kyle/baygit/openvswitch.new/ovs/_debian'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/kyle/baygit/openvswitch.new/ovs/_debian'
> make[1]: *** [build-arch-stamp] Error 2
> make[1]: Leaving directory `/home/kyle/baygit/openvswitch.new/ovs'
> make: *** [build] Error 2
>
> Thanks,
> Kyle Upton
>
>
> On 07/20/2015 02:27 PM, Ben Pfaff wrote:
> > OK, now I need an explanation myself.  The Debian builds worked fine for
> > me both before and after this patch.  What problem do you see?
> >
> > On Mon, Jul 20, 2015 at 11:17:41AM -0700, Alex Wang wrote:
> >> Could I get an explanation on why there is a typo.
> >>
> >> This is breaking debian build on my setup,
> >>
> >> Thanks,
> >> Alex Wang,
> >>
> >> On Tue, Jul 14, 2015 at 10:43 PM, Ben Pfaff <blp at nicira.com> wrote:
> >>
> >>> On Thu, Jul 09, 2015 at 03:22:46PM -0400, Kyle Upton wrote:
> >>>> Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that
> >>>> caused problems when building debian packages.
> >>>>
> >>>> Signed-off-by: Kyle Upton <kupton at baymicrosystems.com>
> >>>
> >>> Thanks, applied to master and backported to branch-2.4 and branch-2.3.
> >>> _______________________________________________
> >>> dev mailing list
> >>> dev at openvswitch.org
> >>> http://openvswitch.org/mailman/listinfo/dev
> >>>
>
> This correspondence, and any attachments or files transmitted with this
> correspondence, contains information which may be confidential and
> privileged and is intended solely for the use of the addressee. Unless you
> are the addressee or are authorized to receive messages for the addressee,
> you may not use, copy, disseminate, or disclose this correspondence or any
> information contained in this correspondence to any third party. If you
> have received this correspondence in error, please notify the sender
> immediately and delete this correspondence and any attachments or files
> transmitted with this correspondence from your system, and destroy any and
> all copies thereof, electronic or otherwise. Your cooperation and
> understanding are greatly appreciated.
>