[ovs-dev] [PATCH branch-2.4] tunneling: Mark gre64 tunneling deprecated.

[Pravin Shelar]

On Tue, Jul 21, 2015 at 3:41 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Tue, Jul 21, 2015 at 12:22 AM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> GRE64 was introduced to extend gre key from 32-bit to 64-bit using
>> gre-key and sequence number field. But GRE64 is not standard
>> protocol. There are not many users of this protocol. Therefore we
>> have decided to deprecate it.
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> I think it's worth noting that this is not upstream, so this will
> bring the in-tree and out-of-tree kernel modules closer together.
>
> I would also change "soon" to be either a specific version number or date.
>
ok, I will mention the release.

>> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
>> index ea9abf9..7ca0729 100644
>> --- a/lib/netdev-vport.c
>> +++ b/lib/netdev-vport.c
>> +        TUNNEL_CLASS("gre64", "gre64_sys", netdev_gre64_init,
>> +                                           NULL,  NULL, NULL),
>> +        TUNNEL_CLASS("ipsec_gre64", "gre64_sys", NULL, NULL, NULL, NULL),
>
> I think ipsec_gre64 should have the same warning as well.
>
> I'm not sure if init() is really the best place to use this since it
> is triggered unconditionally at startup. Maybe it is better to warn
> once on the first gre64 tunnel creation?

ok, I thought class is initialized when first vport is added. but it
is not case. I will add warn in netdev-alloc function.