[ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

Alex Wang alexw at nicira.com
Wed Jul 22 17:39:21 UTC 2015


On Wed, Jul 22, 2015 at 10:32 AM, Russell Bryant <rbryant at redhat.com> wrote:

> On 07/22/2015 01:13 PM, Alex Wang wrote:
> > Thx a lot for the review,
> >
> >
> > On Tue, Jul 21, 2015 at 1:35 PM, Russell Bryant <rbryant at redhat.com
> > <mailto:rbryant at redhat.com>> wrote:
> >
> >     On 07/16/2015 03:56 AM, Alex Wang wrote:
> >     > This commit adds the binding module to ovn-controller-vtep.  The
> >     > module will scan through the Binding table in ovnsb.  If there is
> >     > a binding for a logical port in the vtep gateway chassis's
> >     > "vtep_logical_switches" map, sets the binding's chassis column to
> the
> >     > vtep gateway chassis.
> >     >
> >     > Signed-off-by: Alex Wang <alexw at nicira.com <mailto:
> alexw at nicira.com>>
> >
> >     As discussed before, I'd like to see this done using logical port
> type
> >     and options instead of a special name, but this could be reworked
> later
> >     if it merges before the addition of type and options.
> >
> >     A few comments inline ..
> >
> >
> > Yeah, I think this patch and my last one could just sit in my repo for a
> bit
> > longer...  Once your change is committed, I'll rebase and resubmit~
>
> To be clear, I have no problem with this merging first.  It was ready
> first and there aren't actually any conflicts.  It'll just introduce an
> alternative way to implement part of this and we can convert it later if
> needed.
>


No, I personally prefer this precedence, also I believe there will be
unittest
failure, if you run my series on top of yours which could be messy.



>
> --
> Russell Bryant
>



More information about the dev mailing list