[ovs-dev] [PATCH 2/2] ofproto-dpif.at: Skip a sflow test.

[Ben Pfaff]

Thanks for the correction.

Acked-by: Ben Pfaff <blp at nicira.com>

On Mon, Jul 27, 2015 at 03:38:39PM -0700, Gurucharan Shetty wrote:
> We do use AT_XFAIL_IF in tests:
> 
> grep AT_XFAIL_IF *.at
> 
> json.at:   AT_XFAIL_IF([$PYTHON -c "exit(len(u'\U00010800'))"; test $? -ne 1])
> ofproto-dpif.at:  [AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
> ofproto-dpif.at:AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
> ofproto-dpif.at:AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
> ofproto-dpif.at:AT_XFAIL_IF([test "$IS_WIN32" = "yes"])
> 
> All the invocations in ofproto-dpif are for sflow. I think the
> rationale for that from you long time ago was that, this test is
> supposed to fail because it is not supported and some day we may
> support it. Otherwise, we will forget about the missing feature.
> 
> On Mon, Jul 27, 2015 at 3:30 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Mon, Jul 27, 2015 at 01:44:34PM -0700, Gurucharan Shetty wrote:
> >> sflow is not supported on Windows. So skip the
> >> test.
> >>
> >> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
> >
> > AT_XFAIL_IF and AT_SKIP_IF are different.  I think we only use the
> > latter so far.