[ovs-dev] [PATCH v3 2/2] ofproto: Implement OF1.4 Group & Meter change notification messages

Ben Pfaff blp at nicira.com
Tue Jul 28 15:29:53 UTC 2015


On Tue, Jul 28, 2015 at 05:22:25PM +0530, niti1489 at gmail.com wrote:
> From: Niti Rohilla <niti.rohilla at tcs.com>
> 
> This patch adds support for Openflow1.4 Group & meter change notification
> messages. In a multi controller environment, when a controller modifies the
> state of group and meter table, the request that successfully modifies this
> state is forwarded to other controllers. Other controllers are informed with
> the OFPT_REQUESTFORWARD message. Request forwarding is enabled on a per
> controller channel basis using the Set Asynchronous Configuration Message.
> 
> Signed-off-by: Niti Rohilla <niti.rohilla at tcs.com>

Your function for "re-encoding" requests doesn't actually do it!  It
only changes the version number.  That won't properly account for
differences between OF1.4 and later versions of the protocol, for
example in changes to numbering of OXM fields.

The code needs to use ofputil_*() functions to encode the group_mod and
meter_mod requests properly for the protocol in use.



More information about the dev mailing list