[ovs-dev] [PATCH v3 06/10] ovn: Add patch ports for ovn bridge mappings.

[Russell Bryant]

On 07/28/2015 04:06 PM, Ben Pfaff wrote:
> On Tue, Jul 21, 2015 at 12:59:16PM -0400, Russell Bryant wrote:
>> While parsing the OVN bridge mapping configuration, ensure that patch
>> ports exist between the OVN integration bridge and the physical
>> network bridge.  If they do not exist, create them automatically.
>>
>> Signed-off-by: Russell Bryant <rbryant at redhat.com>
> 
> This looks like a good idea but I have a couple of comments.  First,
> probably this should be adapted so that it's not doing a blocking commit
> (since we've eliminated the others now).  Second, besides adding patch
> ports, I'd expect that it should remove patch ports (that it created)
> when the configuration changes so that they are no longer needed.
> (Probably it should distinguish the ones that ovn-controller owns by
> adding an external-id.)
> 

Both suggestions make sense to me.  I'll incorporate them.

Thanks!

-- 
Russell Bryant