[ovs-dev] [PATCH v2] ofp-print: Abbreviate duplicated table features.

Andy Zhou azhou at nicira.com
Tue Jul 28 21:33:11 UTC 2015


On Mon, Jul 27, 2015 at 1:58 PM, Andy Zhou <azhou at nicira.com> wrote:
> Ben, thanks for rebasing. I will review it soon.
>
> On Mon, Jul 27, 2015 at 1:56 PM, Ben Pfaff <blp at nicira.com> wrote:
>> I spent some time recently looking at the results of "ovs-ofctl
>> dump-table-features".  It was really distressing because of the volume of
>> information.  Every table yielded well over 100 lines of output and for 253
>> (visible) tables that meant over 25,300 lines of output total, which is
>> basically unusable.
>>
>> This commit cuts the volume of output greatly by eliminating most of the
>> duplication from one table to the next.  The command now prints the full
>> output only for table 0, and for each subsequent table prints only the
>> parts that differ.  That reduces the output volume for tables after the
>> first to only 9 lines each (one of which is blank), for a total of more
>> like 2,400 lines, which is still not short but reasonably manageable.
>>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>> ---
>> v1->v2: Rebase.


Nice patch!  It is much simpler and cleaner than I imagined.

Acked-by: Andy Zhou <azhou at nicira.com>



More information about the dev mailing list