[ovs-dev] [PATCH v2 06/21] ovn-controller: Factor encapsulation code out of chassis code.

[Justin Pettit]

> On Jul 28, 2015, at 4:18 PM, Justin Pettit <jpettit at nicira.com> wrote:
> 
> Acked-by: Justin Pettit <jpettit at nicira.com>

I should amend my Ack.  I think this introduces a problem.

> 
>> On Jul 28, 2015, at 8:44 AM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>> 
>> /* Returns true if the database is all cleaned up, false if more work is
>> * required. */
>> bool
>> -chassis_cleanup(struct controller_ctx *ctx, const struct ovsrec_bridge *br_int)
>> +chassis_cleanup(struct controller_ctx *ctx)
>> {
>> -    if (!ctx->ovnsb_idl_txn || !ctx->ovs_idl_txn) {
>> -        return false;
>> -    }

I think you still want to check if "ctx->ovnsb_idl_txn" is null.

>> /* Returns true if the database is all cleaned up, false if more work is
>> * required. */
>> bool
>> -chassis_cleanup(struct controller_ctx *ctx, const struct ovsrec_bridge *br_int)
>> +encaps_cleanup(struct controller_ctx *ctx, const struct ovsrec_bridge *br_int)
>> {
>> -    if (!ctx->ovnsb_idl_txn || !ctx->ovs_idl_txn) {
>> -        return false;
>> -    }

And, here, I think you want to check if "ctx->ovs_idl_txn" is null.

If you agree, there's no reason to repost these patches.

--Justin