[ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

[Sorin Vinturis]

Nithin,

When a packet (NBL) with multiple NB arrives, it is splitted into a list of multiple packets (NBLs) with single NB by the OvsCreateNewNBLsFromMultipleNBs() function. The new NBL list is inserted into the head of the existing NBL list and the execution continues with the processing of the first packet from the new NBL list.

The OvsInitExternalNBLContext() is called for the second packet from the new NBL list and hence the need to change it.

Thanks,
Sorin

-----Original Message-----
From: Nithin Raju [mailto:nithin at vmware.com] 
Sent: Thursday, 30 July, 2015 19:19
To: Sorin Vinturis
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

hi Sorin,
OvsInitExternalNBLContext() is called from OvsStartNBLIngress() which is the function that hooks into NDIS to get hold of packets in the ingress path.

Typically these are packets that are generated by VMs, or it could be generated by an layered driver above OVS.

Under what conditions would a NBL generated by OVS, get processed in OvsStartNBLIngress()?

-- Nithin

> On Jul 1, 2015, at 7:01 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> This BSOD occurred in the context of a packet (NBL) with multiple
> NET_BUFFER(s) (NBs). The reason for the BSOD is due to the marking of 
> NBLs created by OVS as being external and wrongly completing them.
> 
> This patch should be applied both on master and branch 2.4.
> 
> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> Reported-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> Reported-at: 
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvs
> witch_ovs-2Dissues_issues_82&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=fhvbX5Xt
> KdTcw6NAB-9ZhpeR8OCoGr9hIPCT5N4ZDtA&s=wozkLP_z4adCLJ55PdqIHRBkdlEmOrQ8
> PPlDVcoOqII&e=