[ovs-dev] [PATCH v2 15/21] nroff: Add support for 'diagram' XML element for protocol headers.

[Justin Pettit]

> On Jul 29, 2015, at 9:05 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> On Tue, Jul 28, 2015 at 11:31:48PM -0700, Alex Wang wrote:
>> On Tue, Jul 28, 2015 at 8:44 AM, Ben Pfaff <blp at nicira.com> wrote:
>> 
>>> This will be used in documentation for an upcoming change, to document
>>> how Geneve OVN options are encoded.
>>> 
>>> The code in this change is from a series (not yet submitted) that makes
>>> much more extensive use of it for documenting protocol headers.
>>> 
>>> Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> ...
> 
>> Really curious what's the protocol (reference) of writing this
>> (xml->manpage)?
> 
> I've been making it up as I go along, inspired by HTML and Texinfo
> mostly.
> 
>> Also, is the 'return s' redundant?
> 
> Yes, thanks, I removed it.

I gave it a quick look-over, and it seems reasonable.

--Justin