[ovs-dev] [PATCH 2/6] datapath: Constify netlink structs.

[Joe Stringer]

On 30 July 2015 at 10:08, Jesse Gross <jesse at nicira.com> wrote:
> On Wed, Jul 29, 2015 at 12:53 PM, Joe Stringer <joestringer at nicira.com> wrote:
>> Signed-off-by: Joe Stringer <joestringer at nicira.com>
>> ---
>>  datapath/datapath.c | 25 +++++++++++++------------
>>  datapath/datapath.h |  2 +-
>>  2 files changed, 14 insertions(+), 13 deletions(-)
>
> If I remember correctly the reason why these weren't marked const is
> because older kernels had functions that took these parameters as
> non-const and it provoked warnings. However, it seems to me that we
> have mostly redefined the places where these are passed, so perhaps
> it's not an issue anymore. Can you double check to see if that's the
> case? If so, this looks good to me.
>
> Acked-by: Jesse Gross <jesse at nicira.com>

I took a quick scan through my travis build of this, and I don't see
any warnings, eg v2.6.32.65:
https://travis-ci.org/joestringer/openvswitch/jobs/73239310