[ovs-dev] [PATCHv2] odp-util: Combine dpif_backer_support with odp_parms.

Andy Zhou azhou at nicira.com
Wed Jul 1 02:18:03 UTC 2015


On Tue, Jun 30, 2015 at 6:48 PM, Joe Stringer <joestringer at nicira.com> wrote:
> On 30 June 2015 at 17:42, Andy Zhou <azhou at nicira.com> wrote:
>> On Tue, Jun 30, 2015 at 4:52 PM, Joe Stringer <joestringer at nicira.com> wrote:
>>> Both the ofproto layer and the odp-util layer have recently added
>>> notions about fields supported by the datapath. This commit merges the
>>> two into the same structure.
>>
>> while I see the benfits of combining the structure, I am not sure it
>> makes conceptual sense.
>>
>> It seems we need a structure to store per dpif datpath features and
>> this strcture should be defined in ofproto-dpif.h.
>
> Right, dpif_backer_support {} has this at the moment, including flow
> key support, action support, and ufid support.
>
>> odp-util also needs some of the same information, but not all of them,
>> right? Then why not define odp_support
>> as a seperate sturcture that contains only information needed for
>> serialization, and add a a function to fill
>> an odp_support struct  from dpif_backer_support when necessary?
>
> It's true that odp-util doesn't use all of the fields, it just seemed
> simpler to represent it all using the same structure. I could perhaps
> split it into OVS_KEY_ATTR_* fields (odp_support) vs. all other OVS_*
> fields (dpif_backer_support, which includes a nested odp_support).
This sounds O.K.


More information about the dev mailing list