[ovs-dev] [RFC PATCH kernel 07/10] openvswitch: IPv6 support for ovs_tunnel_get_egress_info

Jiri Benc jbenc at redhat.com
Tue Jun 2 16:03:04 UTC 2015


On Mon, 1 Jun 2015 15:07:11 -0700, Jesse Gross wrote:
> On Thu, May 14, 2015 at 11:10 AM, Jiri Benc <jbenc at redhat.com> wrote:
> > diff --git a/net/openvswitch/vport.h b/net/openvswitch/vport.h
> > index b22d45775eb5..ca9ebb9eb0f7 100644
> > --- a/net/openvswitch/vport.h
> > +++ b/net/openvswitch/vport.h
> > +static inline struct dst_entry *ovs_tunnel6_route_lookup(struct sock *sk,
> > +                                                        const struct ovs_key_ip_tunnel *key,
> > +                                                        u32 mark,
> > +                                                        struct flowi6 *fl6,
> > +                                                        u8 protocol)
> > +{
> > +       struct dst_entry *dst;
> > +       int err;
> > +
> > +       if (ipv6_addr_any(&key->ipv6_dst))
> > +               return ERR_PTR(-EAFNOSUPPORT);
> > +       if (WARN_ON_ONCE(!sk))
> > +               return ERR_PTR(-EAFNOSUPPORT);
> 
> It should be OK if we don't have a sk, right? The IPv6 GRE code passes
> in NULL when it does its route lookup.

Right, this is vxlan specific. I'll remove the check.

Thanks,

 Jiri

-- 
Jiri Benc



More information about the dev mailing list