[ovs-dev] [ovsdb speedup v3 19/19] ovsdb-monitor: add json cache

Ben Pfaff blp at nicira.com
Sat Jun 6 21:23:38 UTC 2015


On Mon, Jun 01, 2015 at 12:29:28AM -0700, Andy Zhou wrote:
> On Fri, May 29, 2015 at 1:05 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Thu, Apr 09, 2015 at 06:40:28PM -0700, Andy Zhou wrote:
> > The current implementation of ovsdb_monitor_commit() throws away the
> > cache whenever there is any commit to the database.  However, most
> > monitors do not every table and every column.  Do you think it would be
> > worthwhile flushing the cache only when a column that is included in the
> > monitor changes?
> >
> This is a good idea.  However, I don't see a way to easily extend current patch
> to add this patch. So I sent out v4 without this enhancement.

I am OK with this patch set without the enhancement; it could be added
later.  But I don't see why it requires much more work.  It seems to me
like the code already looks at each of the changes; why not just flush
only if one of the changes affects a column that the monitor looks at?



More information about the dev mailing list