[ovs-dev] [PATCH] netdev-windows: Fixed unresolved external symbols linker error

[Gurucharan Shetty]

On Mon, Jun 8, 2015 at 7:25 AM, Sorin Vinturis
<svinturis at cloudbasesolutions.com> wrote:
> Adding missing dependency to iphlpapi library, required by the use of
> GetIpNetTable and GetAdaptersAddresses functions.
>
> Without this change the build fails with the error below:
>
> LINK : utilities/ovs-testcontroller.exe not found or not built by the
> last incremental link; performing full link
> libopenvswitch.lib(netdev-windows.obj) : error LNK2019: unresolved
>  external symbol _GetIpNetTable at 12 referenced in function
>  _netdev_windows_netdev_from_ofpbuf
> libopenvswitch.lib(netdev-windows.obj) : error LNK2019: unresolved
>  external symbol _GetAdaptersAddresses at 20 referenced in function
>  _netdev_windows_netdev_from_ofpbuf
> utilities/ovs-testcontroller.exe : fatal error LNK1120: 2 unresolved
>  externals
> make[2]: *** [utilities/ovs-testcontroller.exe] Error 96
>
> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
The build does not fail. See here:
https://ci.appveyor.com/project/blp/ovs/history

Are you using the right configure options?
i.e: ./configure CC=./build-aux/cccl LD="`which link`"
LIBS="-lws2_32 -liphlpapi"

> ---
>  lib/automake.mk   | 1 +
>  m4/openvswitch.m4 | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/lib/automake.mk b/lib/automake.mk
> index 7a34c1a..0ae013f 100644
> --- a/lib/automake.mk
> +++ b/lib/automake.mk
> @@ -11,6 +11,7 @@ lib_libopenvswitch_la_LIBADD = $(SSL_LIBS)
>
>  if WIN32
>  lib_libopenvswitch_la_LIBADD += ${PTHREAD_LIBS}
> +lib_libopenvswitch_la_LIBADD += ${IPHLPAPILIB}
>  endif
>
>  lib_libopenvswitch_la_LDFLAGS = \
> diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
> index 2b84b44..c6855dd 100644
> --- a/m4/openvswitch.m4
> +++ b/m4/openvswitch.m4
> @@ -89,9 +89,11 @@ AC_DEFUN([OVS_CHECK_WIN32],
>              PTHREAD_INCLUDES="-I$withval/include"
>              PTHREAD_LDFLAGS="-L$withval/lib/x86"
>              PTHREAD_LIBS="-lpthreadVC2"
> +            IPHLPAPILIB="-liphlpapi"
>              AC_SUBST([PTHREAD_INCLUDES])
>              AC_SUBST([PTHREAD_LDFLAGS])
>              AC_SUBST([PTHREAD_LIBS])
> +            AC_SUBST([IPHLPAPILIB])
>                ;;
>              esac
>           ], [
> --
> 1.9.0.msysgit.0
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev