[ovs-dev] [PATCH] netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.

Andy Zhou azhou at nicira.com
Mon Jun 8 20:56:23 UTC 2015


On Fri, Jun 5, 2015 at 10:09 PM, Ben Pfaff <blp at nicira.com> wrote:
> Ignoring the result of this function means that the caller is quite likely
> blindly using the character array passed in, instead of the return value,
> which leads to latent bugs.
>
> This would have prevented one of the bugs fixed by commit "tunneling: Fix a
> tunnel name display bug".
>
> CC: Andy Zhou <azhou at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Good idea.

Acked-by: Andy Zhou <azhou at nicira.com>



More information about the dev mailing list