[ovs-dev] [PATCH v6] This commit adds the windows installer to the OVS tree.

Alin Serdean aserdean at cloudbasesolutions.com
Mon Jun 8 23:00:58 UTC 2015


Hi Guru,

1. No that should not happen. 
Mind running the following command and send me offline the file log.txt so I can see what happens?
 " msiexec /i OpenvSwitch.msi ADDLOCAL=ALL /qn /l*v log.txt "

2. In the installer I set up the following environment variables:
https://github.com/openvswitch/ovs/blob/master/windows/ovs-windows-installer/Product.wxs#L143-L154
I did this because the installation directory may differ from one user to another.
Since environment variables takes precedence before default values passed to ./configure it should suffice.
I could write in the documentation about it and also maybe make a topic on how to use configure with the default path ('C:\Program Files...')

3. I will update INSTALL.Windows.md on how to build the installer.


Thanks,
Alin .

-----Mesaj original-----
De la: Gurucharan Shetty [mailto:shettyg at nicira.com] 
Trimis: Monday, June 8, 2015 12:43 AM
Către: Alin Serdean
Cc: dev at openvswitch.org
Subiect: Re: [PATCH v6] This commit adds the windows installer to the OVS tree.

On Fri, Jun 5, 2015 at 4:23 PM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
> Rebased and added the sign off:
>
> https://github.com/openvswitch/ovs/pull/50
Thank you Alin! I applied this. There are a couple of things that I noticed.

1. While installing, I got a dialog box which said: "The file OVSExt.sys on Open vSwitch extension is needed. Type the path where it is located and click OK". The installation went through after I gave the path. Do you know whats going on there? Looks like a bug to me.
2. Right now, for instructions, we are asking people to provide the C:/openvswitch as configure options. What it does is that it make C:/openvswitch as the default directory where OVS daemons will look for some files or create some files when absolute paths are not given.
It looked like you are providing the correct paths while starting utilities and daemons, so it probably works. But if you run commands without providing these default paths, it will be a problem. Since you are installing things in 'c/Program Files', have you looked at providing those paths as options while running ./configure. If that strategy works, it will make it simpler running utilities to debug the system.
3. INSTALL.Windows currently asks people to do a 'make install' as an option to install daemons and utilities. Out there, can you also mention about how they can use make windows_installer to install?

Thanks again for all your contributions to the Open vSwitch project on Windows. This is a milestone!

>
> Alin.
>
> -----Mesaj original-----
> De la: dev [mailto:dev-bounces at openvswitch.org] În numele Alin Serdean
> Trimis: Friday, June 5, 2015 9:20 PM
> Către: Gurucharan Shetty
> Cc: dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v6] This commit adds the windows installer to the OVS tree.
>
> Sure.
>
> Alin.
>
> -----Mesaj original-----
> De la: Gurucharan Shetty [mailto:shettyg at nicira.com]
> Trimis: Friday, June 5, 2015 5:57 PM
> Către: Alin Serdean
> Cc: dev at openvswitch.org; Nithin Raju; Eitan Eliahu
> Subiect: Re: [PATCH v6] This commit adds the windows installer to the OVS tree.
>
> Alin,
>  I do not see Alessandro's signed-off. Can you please add.
>
> On Fri, Jun 5, 2015 at 5:16 AM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
>> Sorry but unfortunately I could not get the patch on the ML.
>> Created the following pull request instead: https://github.com/openvswitch/ovs/pull/49 .
>>
>> Thank you,
>> Alin.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev


More information about the dev mailing list