[ovs-dev] [PATCH v4 11/12] ofproto: Use minimatch for making bundles smaller.
Ben Pfaff
blp at nicira.com
Thu Jun 11 00:53:10 UTC 2015
On Wed, Jun 10, 2015 at 05:52:21PM -0700, Jarno Rajahalme wrote:
>
> > On Jun 10, 2015, at 5:46 PM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > On Tue, Jun 09, 2015 at 05:24:18PM -0700, Jarno Rajahalme wrote:
> >> struct match in ofputil_flow_mod uses a lot of space, when used for a
> >> stored bundle message. This patch adds a new struct
> >> ofputil_miniflow_mod, that uses a minimatch instead of match in hopes
> >> of using less memory when handling large bundles.
> >>
> >> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> >
> > Hmm. It's uglier than I expected. Might still be worthwhile.
> >
> > I wonder whether it would be a big deal to change ofputil_flow_mod to
> > always use a minimatch?
>
> I tried that briefly and decided at that time that it is too much
> work. But I might try again and take a better look.
This whole idea might be "premature optimization"; not sure.
More information about the dev
mailing list