[ovs-dev] [PATCH] ovs-rcu: Comment fixes.

Ben Pfaff blp at nicira.com
Fri Jun 12 22:43:11 UTC 2015


Thanks!  Applied.

On Fri, Jun 12, 2015 at 11:00:10AM -0700, Alex Wang wrote:
> Acked-by: Alex Wang <alexw at nicira.com>
> 
> On Fri, Jun 12, 2015 at 10:58 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > A comment referred to a "Usage" section but the section was named "Use".
> > This fixes the problem (also a grammar error).
> >
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> >  lib/ovs-rcu.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/ovs-rcu.h b/lib/ovs-rcu.h
> > index c1e3d60..5cd4152 100644
> > --- a/lib/ovs-rcu.h
> > +++ b/lib/ovs-rcu.h
> > @@ -1,5 +1,5 @@
> >  /*
> > - * Copyright (c) 2014 Nicira, Inc.
> > + * Copyright (c) 2014, 2015 Nicira, Inc.
> >   *
> >   * Licensed under the Apache License, Version 2.0 (the "License");
> >   * you may not use this file except in compliance with the License.
> > @@ -80,8 +80,8 @@
> >   * All functions postponed by a single thread are guaranteed to execute
> > in the
> >   * order they were postponed, however.
> >   *
> > - * Use
> > - * ---
> > + * Usage
> > + * -----
> >   *
> >   * Use OVSRCU_TYPE(TYPE) to declare a pointer to RCU-protected data, e.g.
> > the
> >   * following declares an RCU-protected "struct flow *" named flowp:
> > @@ -204,7 +204,7 @@ static inline void ovsrcu_set__(struct ovsrcu_pointer
> > *pointer,
> >  #define ovsrcu_init(VAR, VALUE) atomic_init(&(VAR)->p, VALUE)
> >
> >  /* Calls FUNCTION passing ARG as its pointer-type argument following the
> > next
> > - * grace period.  See "Usage" above for example.  */
> > + * grace period.  See "Usage" above for an example. */
> >  void ovsrcu_postpone__(void (*function)(void *aux), void *aux);
> >  #define ovsrcu_postpone(FUNCTION, ARG)                          \
> >      ((void) sizeof((FUNCTION)(ARG), 1),                         \
> > --
> > 2.1.3
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >



More information about the dev mailing list