[ovs-dev] [PATCH] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch

Alin Serdean aserdean at cloudbasesolutions.com
Thu Jun 18 21:00:22 UTC 2015


Delete internal port
Test connectivity
Add internal port
Test connectivity

Delete external port
Test connectivity
Add external port
Test connectivity

Delete internal port
Delete external port
Test connectivity
Add internal port
Test connectivity
Add external port
Test connectivity

Uninstall extension verify port deletion.

Alin.

-----Mesaj original-----
De la: dev [mailto:dev-bounces at openvswitch.org] În numele Nithin Raju
Trimis: Thursday, June 18, 2015 11:30 PM
Către: Sorin Vinturis
Cc: dev at openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch

> On Jun 18, 2015, at 11:52 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> Disconnecting the NIC from HV switch and then unloading the driver 
> hits an ASSERT (ASSERT(switchContext->numPhysicalNics);).
> 
> Also if the external or internal port is deleted from the userspace, 
> the latter ports would not be re-added until the extension would be reloaded.
> 
> This patch ensures that the internal or external ports are being 
> deleted only by the Hyper-V switch mechanisms, which also solves the 
> issue raised by the above assert.
> 
> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> Co-authored-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> Reported-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>

Just curious, was any unit testing performed to test the specific scenario we are claiming to fix?

thanks,
-- Nithin
_______________________________________________
dev mailing list
dev at openvswitch.org
http://openvswitch.org/mailman/listinfo/dev


More information about the dev mailing list