[ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

Gurucharan Shetty shettyg at nicira.com
Mon Jun 22 23:45:17 UTC 2015


On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean
<aserdean at cloudbasesolutions.com> wrote:
> On Windows the following tests hang unless we also call
> the OVS_VSWITCHD_STOP macro to stop the executable.

This concerns me a bit. In _OVS_VSWITCHD_START, we call
ON_EXIT_UNQUOTED([kill `cat ovs-vswitchd.pid`])
ON_EXIT_UNQUOTED([kill `cat ovsdb-server.pid`])

So when AT_CLEANUP is called, this should call tskill $pid for both
ovs-vswitchd and ovsdb-server; This is force kill in Windows.

OVS_VSWITCHD_STOP simply calls 'ovs-appctl -t ovsdb-server exit' and
'ovs-appctl exit' which is clean kill.

So why is that force-kill not working? If you run one of the hanging
test alone, is this hang reproducible every time? If so, 'tasklist |
grep ovs' should you the ovs process that is still running.

Can you see why it is not getting killed?

>
> Tested on Windows and Linux
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> ---
>  tests/bfd.at | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tests/bfd.at b/tests/bfd.at
> index 8bf88f2..5215d2e 100644
> --- a/tests/bfd.at
> +++ b/tests/bfd.at
> @@ -442,6 +442,7 @@ done
>  BFD_CHECK([p0], [false], [false], [none], [down], [No Diagnostic], [none], [down], [No Diagnostic])
>
>  AT_CHECK([ovs-vsctl del-br br1], [0], [ignore])
> +OVS_VSWITCHD_STOP
>  AT_CLEANUP
>
>
> @@ -509,6 +510,7 @@ BFD_CHECK_TX([p0], [500ms], [500ms], [300ms])
>  BFD_CHECK_RX([p0], [500ms], [500ms], [300ms])
>
>  AT_CHECK([ovs-vsctl del-br br1], [0], [ignore])
> +OVS_VSWITCHD_STOP
>  AT_CLEANUP
>
>  # forwarding_if_rx Test3
> @@ -596,6 +598,7 @@ BFD_CHECK_TX([p0], [300ms], [300ms], [300ms])
>  BFD_CHECK_RX([p0], [1000ms], [1000ms], [300ms])
>
>  AT_CHECK([ovs-vsctl del-br br1], [0], [ignore])
> +OVS_VSWITCHD_STOP
>  AT_CLEANUP
>
>  # forwarding_if_rx Test4
> @@ -664,6 +667,7 @@ done
>  BFD_CHECK([p0], [false], [false], [none], [down], [Control Detection Time Expired], [none], [down], [No Diagnostic])
>
>  AT_CHECK([ovs-vsctl del-br br1], [0], [ignore])
> +OVS_VSWITCHD_STOP
>  AT_CLEANUP
>
>  # test bfd:flap_count.
> --
> 1.9.5.msysgit.0
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list