[ovs-dev] [PATCH] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch

[Ben Pfaff]

Should I take that as a positive review?

On Fri, Jun 19, 2015 at 06:51:17AM +0000, Nithin Raju wrote:
> Thanks Alin.
> 
> > On Jun 18, 2015, at 2:00 PM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
> > 
> > Delete internal port
> > Test connectivity
> > Add internal port
> > Test connectivity
> > 
> > Delete external port
> > Test connectivity
> > Add external port
> > Test connectivity
> > 
> > Delete internal port
> > Delete external port
> > Test connectivity
> > Add internal port
> > Test connectivity
> > Add external port
> > Test connectivity
> > 
> > Uninstall extension verify port deletion.
> > 
> > Alin.
> > 
> > -----Mesaj original-----
> > De la: dev [mailto:dev-bounces at openvswitch.org] În numele Nithin Raju
> > Trimis: Thursday, June 18, 2015 11:30 PM
> > Către: Sorin Vinturis
> > Cc: dev at openvswitch.org
> > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch
> > 
> >> On Jun 18, 2015, at 11:52 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> >> 
> >> Disconnecting the NIC from HV switch and then unloading the driver 
> >> hits an ASSERT (ASSERT(switchContext->numPhysicalNics);).
> >> 
> >> Also if the external or internal port is deleted from the userspace, 
> >> the latter ports would not be re-added until the extension would be reloaded.
> >> 
> >> This patch ensures that the internal or external ports are being 
> >> deleted only by the Hyper-V switch mechanisms, which also solves the 
> >> issue raised by the above assert.
> >> 
> >> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> >> Co-authored-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> >> Reported-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> > 
> > Just curious, was any unit testing performed to test the specific scenario we are claiming to fix?
> > 
> > thanks,
> > -- Nithin
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=q1cb-T2pctLQnNJ2OwKlv_RsKbtpJ8FPjBJ-W5p_9vU&s=nWK_z-UHuGNF1B0MBF0RTfbwqrzr85wc920kbDvQWCU&e= 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev