[ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

[Gurucharan Shetty]

You can look at "commit 5e65e080ad4d57e" for more information on the
exact problem with taskkill.

One option is to check for tskill and if it does not exist, use taskkill.

On Tue, Jun 23, 2015 at 6:37 PM, Alin Serdean
<aserdean at cloudbasesolutions.com> wrote:
> Think I found why tskill is missing on my system. It is part of the role remote desktop services role https://technet.microsoft.com/en-us/library/cc725766.aspx while taskkill is part of the default installation.
>
> Theoretically taskkill with option /f
> "Specifies that processes be forcefully terminated. This parameter is ignored for remote processes; all remote processes are forcefully terminated."
> and /t
> " Terminates the specified process and any child processes started by it."
> would suffice.
>
> Alin.
>
> -----Mesaj original-----
> De la: Gurucharan Shetty [mailto:shettyg at nicira.com]
> Trimis: Tuesday, June 23, 2015 5:40 PM
> Către: Alin Serdean
> Cc: dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests
>
> I applied this patch as-is. We still need to figure out the issue around tskill.
>
> On Tue, Jun 23, 2015 at 7:05 AM, Gurucharan Shetty <shettyg at nicira.com> wrote:
>> On Mon, Jun 22, 2015 at 5:21 PM, Alin Serdean
>> <aserdean at cloudbasesolutions.com> wrote:
>>> I could send another patch with the following:
>>> -                        tskill $i
>>> +                        taskkill //PID $i //F >/dev/null
>>>
>>> Alin.
>>
>> Your current patch is something that I think we should apply because
>> from Windows' perspective it does a clean kill instead of the force
>> kill.
>>
>> Do you know why your system does not have tskill? The code originally
>> had taskkill instead of tskill. One thing I observed was that taskkill
>> cannot kill deadlocked processes and unit tests would hang whenever
>> processes deadlock. That is the reason I changed it to tskill.