[ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

Ben Pfaff blp at nicira.com
Wed Jun 24 18:04:44 UTC 2015


I guess this solution is OK with me for 2.4.  Nithin (or anyone), do you
agree that it's the best solution for now?

On Fri, Jun 19, 2015 at 04:41:47PM +0000, Alin Serdean wrote:
> To do it the proper way yes.
> 
> I really hate to do it this way but given the timeframe for 2.4 we could nuke it later on.
> 
> Alin.
> 
> -----Mesaj original-----
> De la: Nithin Raju [mailto:nithin at vmware.com] 
> Trimis: Friday, June 19, 2015 7:36 PM
> Către: Alin Serdean
> Cc: dev at openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath
> 
> hi Alin,
> Do you know what is required to complete the implementation of dpif_probe_feature() in the Windows datapath? Is it the flow validation logic?
> 
> thanks,
> -- Nithin
> 
> 
> > On Jun 18, 2015, at 6:47 PM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
> > 
> > This patch disables features which are not currently supported in the 
> > windows datapath.
> > 
> > Unfortunately we have to do it in userspace because dpif_probe_feature 
> > is not treated accordingly in the windows the datapath.
> > 
> > I opened the issue to track the feature for later implementations:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvs
> > witch_ovs-2Dissues_issues_85&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> > YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=H9ymRGwE
> > SDpjH0qHp5EifPK6QimZgzvHEIyjM3QzRwg&s=-rOo7BG2BoxcGi2BlSQASDz8v5Hkhp4y
> > MoGbPZ-zQus&e=
> > ---
> > v2: Rebase
> > ---
> > ofproto/ofproto-dpif.c | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> > 
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 
> > 0de8686..55d004e 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -1014,8 +1014,14 @@ check_recirc(struct dpif_backer *backer)
> > 
> >     ofpbuf_use_stack(&key, &keybuf, sizeof keybuf);
> >     odp_flow_key_from_flow(&odp_parms, &key);
> > +#ifdef _WIN32
> > +    /* XXX Force disable of datapath recirculation from userspace until the
> > +     * dpif_probe_feature is properly implemented in the windows datapath */
> > +    enable_recirc = false;
> > +#else
> >     enable_recirc = dpif_probe_feature(backer->dpif, "recirculation", &key,
> >                                        NULL);
> > +#endif
> > 
> >     if (enable_recirc) {
> >         VLOG_INFO("%s: Datapath supports recirculation", @@ -1052,7 
> > +1058,13 @@ check_ufid(struct dpif_backer *backer)
> >     odp_flow_key_from_flow(&odp_parms, &key);
> >     dpif_flow_hash(backer->dpif, key.data, key.size, &ufid);
> > 
> > +#ifdef _WIN32
> > +    /* XXX Force disable of datapath recirculation from userspace until the
> > +     * dpif_probe_feature is properly implemented in the windows datapath */
> > +    enable_ufid = false;
> > +#else
> >     enable_ufid = dpif_probe_feature(backer->dpif, "UFID", &key, 
> > &ufid);
> > +#endif
> > 
> >     if (enable_ufid) {
> >         VLOG_INFO("%s: Datapath supports unique flow ids", @@ -1161,6 
> > +1173,11 @@ check_max_mpls_depth(struct dpif_backer *backer)
> > 
> >         ofpbuf_use_stack(&key, &keybuf, sizeof keybuf);
> >         odp_flow_key_from_flow(&odp_parms, &key);
> > +#ifdef _WIN32
> > +        /* XXX Force disable of datapath recirculation from userspace until the
> > +         * dpif_probe_feature is properly implemented in the windows datapath */
> > +        break;
> > +#endif
> >         if (!dpif_probe_feature(backer->dpif, "MPLS", &key, NULL)) {
> >             break;
> >         }
> > --
> > 1.9.5.msysgit.0
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_ma
> > ilman_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-
> > uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=H9ymRGwESDpjH0qHp5
> > EifPK6QimZgzvHEIyjM3QzRwg&s=voVGofZZJTP055uwJnpQBjFDxPbFyaiHEtEtt140MO
> > E&e=
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list