[ovs-dev] [PATCH 02/11] nx-match: Support variable length header lookup.

Ben Pfaff blp at nicira.com
Wed Jun 24 18:13:49 UTC 2015


On Fri, Jun 19, 2015 at 04:13:16PM -0700, Jesse Gross wrote:
> Currently we treat the entire NXM/OXM header, including length,
> as an ID to define a field. However, this does not allow for
> multiple lengths of a particular field.
> 
> If a field has been marked as variable, we should ignore the length
> when looking up the field and only use the class and field. We
> continue to use the length for non-variable fields to ensure that
> we don't accept something that can never match.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

"sparse" says:

    ../lib/nx-match.c:100:63: warning: constant 0xffffff80ffffffff is so big it is unsigned long long

so I'd suggest adding a ULL suffix there (even though the warning does
make me just think "duh").

While reading nxm_field_by_header() I realized that we've got a terrible
existing mistake in our hashing.  Ugh. I'll send a fix, which we'll want
to pre-apply (and maybe backport).



More information about the dev mailing list