[ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

Jesse Gross jesse at nicira.com
Wed Jun 24 20:45:48 UTC 2015


On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote:
>> Tunnel metadata can be substantially larger than our existing fields
>> (up to 124 bytes in a single Geneve option) so this extends the size
>> of the data that we can handle with metaflow fields. This also
>> breaks a few tests that assume that their max size is also the
>> maximum that can be handled in a field.
>>
>> Signed-off-by: Jesse Gross <jesse at nicira.com>
>
> Did you look around at all to see whether this will unreasonably blow up
> any data or algorithms?

I don't believe that it should have any significant effects.
Generally, code does operations on the fields based on mf->n_bytes
(with the exception of some memset()s here and there). I don't think
that we really store these in a large number for any real period of
time.



More information about the dev mailing list