[ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

Ben Pfaff blp at nicira.com
Thu Jun 25 00:25:23 UTC 2015


On Tue, Jun 23, 2015 at 08:11:22AM -0700, Sabyasachi Sengupta wrote:
> Extend bfd to save wall clock time of the last flap in bfd_forwarding__,
> and display it throught bfd/show. This information is also exported out
> to ovsdb in bfd_get_status.
> 
> Signed-off-by: Sabyasachi Sengupta <sabyasachi.sengupta at alcatel-lucent.com>

This seems useful, although I could not apply the patch:

    Applying: bfd: display last wall clock time of last flap
    fatal: corrupt patch at line 55
    Patch failed at 0001 bfd: display last wall clock time of last flap
    The copy of the patch that failed is found in:
       /home/blp/nicira/ovs/.git/rebase-apply/patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

It's a little unconventional for us to use a wall clock time for this.
I'd be more inclined to report it as "N seconds ago" or "N ms ago".  Any
particular reason to use a wall clock time?

Please also document the new bfd_status feature in vswitchd/vswitch.xml
near the rest of the bfd_status keys.



More information about the dev mailing list