[ovs-dev] [PATCH 1/2] Committing two issues:

[Garg, Sumit]

Hello Ben, no worries.

Still figuring my way around git, github etc. So, please excuse by
missteps (e.g. subject lines).


I've redone (revert + recommit) changes to my fork with a better commit
message.

Will, be sending the patch (via email) & pull request (via github) shortly.

Let's handle the "initialize new row" as a separate activity.
--
Sumit Garg
Extreme Networks
sumit at extremenetworks.com
+1 (919) 595-4971







On 6/24/15, 7:40 PM, "Ben Pfaff" <blp at nicira.com> wrote:

>Hi Sumit.  Sorry it took me a while to review this--I'm catching up as
>best I can.
>
>Can I have a Signed-off-by for this commit?  CONTRIBUTING.md says this
>about Signed-off-by:
>
>    Signed-off-by: Author Name <author.name at email.address...>
>
>        Informally, this indicates that Author Name is the author or
>        submitter of a patch and has the authority to submit it under
>        the terms of the license.  The formal meaning is to agree to
>        the Developer's Certificate of Origin (see below).
>
>        If the author and submitter are different, each must sign off.
>        If the patch has more than one author, all must sign off.
>
>        Signed-off-by: Author Name <author.name at email.address...>
>        Signed-off-by: Submitter Name <submitter.name at email.address...>
>
>and its meaning is:
>
>Developer's Certificate of Origin
>---------------------------------
>
>To help track the author of a patch as well as the submission chain,
>and be clear that the developer has authority to submit a patch for
>inclusion in openvswitch please sign off your work.  The sign off
>certifies the following:
>
>    Developer's Certificate of Origin 1.1
>
>    By making a contribution to this project, I certify that:
>
>    (a) The contribution was created in whole or in part by me and I
>        have the right to submit it under the open source license
>        indicated in the file; or
>
>    (b) The contribution is based upon previous work that, to the best
>        of my knowledge, is covered under an appropriate open source
>        license and I have the right under that license to submit that
>        work with modifications, whether created in whole or in part
>        by me, under the same open source license (unless I am
>        permitted to submit under a different license), as indicated
>        in the file; or
>
>    (c) The contribution was provided directly to me by some other
>        person who certified (a), (b) or (c) and I have not modified
>        it.
>
>    (d) I understand and agree that this project and the contribution
>        are public and that a record of the contribution (including all
>        personal information I submit with it, including my sign-off) is
>        maintained indefinitely and may be redistributed consistent with
>        this project or the open source license(s) involved.
>
>More below.
>
>On Sat, Jun 20, 2015 at 05:09:54PM -0700, Ben Pfaff wrote:
>> From: Sumit Garg <sumit at extremenetworks.com>
>>
>> 1. A bool (has_lock) was being accessed as a function call
>>    leading to a runtime exception.
>
>This seems obviously correct, I'll happily commit it when I have a
>signoff.
>
>> 2. When 'alert' was turned off on a column, the code was
>>    erroring out when value for that column was being set
>>    in a newly inserted row. This is because the row._data
>>    was None at this time.
>>
>> A question related to change #2 - should a newly inserted
>> row get automatically intialized to default values? If so,
>> I'm not sure the initialization to defaults is happening
>> and maybe that's why I'm seeing the NULL error. Either way,
>> I don't see an issue with adding the additional check.
>
>I think it would be better to initialize a new row to defaults but the
>code doesn't do that at the moment.  I'm happy to take this change.


________________________________

DISCLAIMER:
This e-mail and any attachments to it may contain confidential and proprietary material and is solely for the use of the intended recipient. Any review, use, disclosure, distribution or copying of this transmittal is prohibited except by or on behalf of the intended recipient. If you have received this transmittal in error, please notify the sender and destroy this e-mail and any attachments and all copies, whether electronic or printed.