[ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.
Ben Pfaff
blp at nicira.com
Wed Apr 1 00:05:05 UTC 2015
On Tue, Mar 31, 2015 at 10:14:55AM -0700, Justin Pettit wrote:
>
> > On Mar 31, 2015, at 8:31 AM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > + If STP is enabled on the bridge (see the <ref column="stp_enable"
> > + table="Open_vSwitch"/> column in the <ref table="Bridge"/> table),
>
> I think that should be "Bridge" instead of "Open_vSwitch".
>
> > + Set this option to <code>true</code> if the Open vSwitch bridge
> > + connects different Ethernet networks and does not run STP.
>
> This reads ambiguous to me whether the bridge or network is not running STP. How about something like the following?
>
> Set this option to <code>true</code> if the Open vSwitch bridge
> connects different Ethernet networks and is not configured to
> participate in STP.
>
> I'd like to hear from Brian, but it looks like an improvement to me:
>
> Acked-by: Justin Pettit <jpettit at nicira.com>
Thanks, I made those changes.
More information about the dev
mailing list