[ovs-dev] [PATCH 0/4] lib: Simplify packet buffer lib.

Pravin B Shelar pshelar at nicira.com
Mon Mar 2 18:51:21 UTC 2015


ofpbuf is used as central structure for managing all buffers
in OVS, this complicates its implementation. Specially for
DPDK case where some of members are mapped to DPDK mbuf which
are defined for network packet and are of different datatype type.
This patch series defines datapath and generic buffer management
into separate lib so that we can improve these modules independently.

Pravin B Shelar (4):
  ofpbuf: simplify ofpbuf_l4_size()
  dpif_packet: Rename to dp_packet
  dp-packet: Remove ofpbuf dependency.
  ofpbuf: Simplify ofpbuf API.

 lib/automake.mk                |    4 +-
 lib/bfd.c                      |   23 +-
 lib/bfd.h                      |    6 +-
 lib/bundle.c                   |    2 +-
 lib/cfm.c                      |   12 +-
 lib/cfm.h                      |    6 +-
 lib/dp-packet.c                |  569 ++++++++++++++++++++++++++++++++++++++++
 lib/dp-packet.h                |  481 +++++++++++++++++++++++++++++++++
 lib/dpctl.c                    |   41 ++--
 lib/dpif-netdev.c              |  138 +++++------
 lib/dpif-netdev.h              |    8 +-
 lib/dpif-netlink.c             |   34 ++--
 lib/dpif.c                     |   45 ++--
 lib/dpif.h                     |   11 +-
 lib/flow.c                     |   79 +++---
 lib/flow.h                     |   32 +--
 lib/jsonrpc.c                  |    6 +-
 lib/lacp.c                     |    8 +-
 lib/lacp.h                     |    2 +-
 lib/learn.c                    |    6 +-
 lib/learning-switch.c          |   27 +-
 lib/netdev-bsd.c               |   47 ++--
 lib/netdev-dpdk.c              |   37 ++--
 lib/netdev-dpdk.h              |    6 +-
 lib/netdev-dummy.c             |  101 ++++----
 lib/netdev-linux.c             |   43 ++--
 lib/netdev-provider.h          |    8 +-
 lib/netdev-vport.c             |   63 ++---
 lib/netdev.c                   |   12 +-
 lib/netdev.h                   |   10 +-
 lib/netlink-socket.c           |   76 +++---
 lib/netlink.c                  |   26 +-
 lib/nx-match.c                 |   50 ++--
 lib/odp-execute.c              |  127 ++++-----
 lib/odp-execute.h              |    6 +-
 lib/odp-util.c                 |   16 +-
 lib/ofp-actions.c              |  131 +++++-----
 lib/ofp-errors.c               |    4 +-
 lib/ofp-msgs.c                 |   76 +++---
 lib/ofp-parse.c                |    8 +-
 lib/ofp-print.c                |   26 +-
 lib/ofp-util.c                 |  374 +++++++++++++-------------
 lib/ofpbuf.c                   |  173 ++++---------
 lib/ofpbuf.h                   |  294 ++-------------------
 lib/packet-dpif.c              |   71 -----
 lib/packet-dpif.h              |   73 -----
 lib/packets.c                  |  158 ++++++------
 lib/packets.h                  |   34 ++--
 lib/pcap-file.c                |   48 ++--
 lib/pcap-file.h                |   10 +-
 lib/rconn.c                    |   18 +-
 lib/route-table.c              |    2 +-
 lib/rstp-common.h              |    2 +-
 lib/rstp-state-machines.c      |   15 +-
 lib/rstp.c                     |    3 +-
 lib/rstp.h                     |    4 +-
 lib/rtnetlink-link.c           |    2 +-
 lib/stp.c                      |   19 +-
 lib/stp.h                      |    4 +-
 lib/tnl-arp-cache.c            |    2 +-
 lib/tnl-ports.c                |    8 +-
 lib/vconn-stream.c             |   22 +-
 lib/vconn.c                    |   28 +-
 ofproto/bond.c                 |    7 +-
 ofproto/bond.h                 |    2 +-
 ofproto/connmgr.c              |    6 +-
 ofproto/connmgr.h              |    2 +-
 ofproto/fail-open.c            |   17 +-
 ofproto/in-band.c              |    2 +-
 ofproto/netflow.c              |   12 +-
 ofproto/ofproto-dpif-ipfix.c   |  101 ++++----
 ofproto/ofproto-dpif-ipfix.h   |    6 +-
 ofproto/ofproto-dpif-monitor.c |   19 +-
 ofproto/ofproto-dpif-sflow.c   |    8 +-
 ofproto/ofproto-dpif-sflow.h   |    2 +-
 ofproto/ofproto-dpif-upcall.c  |   62 ++---
 ofproto/ofproto-dpif-xlate.c   |   96 ++++----
 ofproto/ofproto-dpif-xlate.h   |    7 +-
 ofproto/ofproto-dpif.c         |  125 +++++-----
 ofproto/ofproto-dpif.h         |    6 +-
 ofproto/ofproto-provider.h     |    4 +-
 ofproto/ofproto.c              |   25 +-
 ofproto/pktbuf.c               |   16 +-
 ofproto/pktbuf.h               |    4 +-
 tests/test-bundle.c            |    2 +-
 tests/test-flows.c             |   11 +-
 tests/test-netflow.c           |    6 +-
 tests/test-odp.c               |   22 +-
 tests/test-rstp.c              |    9 +-
 tests/test-sflow.c             |    6 +-
 tests/test-stp.c               |    9 +-
 tests/test-vconn.c             |   10 +-
 utilities/ovs-ofctl.c          |  190 +++++++-------
 vswitchd/bridge.c              |    4 +-
 94 files changed, 2546 insertions(+), 2029 deletions(-)
 create mode 100644 lib/dp-packet.c
 create mode 100644 lib/dp-packet.h
 delete mode 100644 lib/packet-dpif.c
 delete mode 100644 lib/packet-dpif.h




More information about the dev mailing list