[ovs-dev] [PATCH 2/7] odp-util: Fix scanning of recirc_id.

[Ben Pfaff]

On Tue, Mar 03, 2015 at 10:46:29AM -0800, Jarno Rajahalme wrote:
> 
> > On Mar 3, 2015, at 9:55 AM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > On Tue, Feb 24, 2015 at 03:42:01PM -0800, Jarno Rajahalme wrote:
> >> Recirculation id was scanned without a mask, which led to it being
> >> ignored.
> >> 
> >> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> > 
> > Do you know what the idea was here?  Is it just that it doesn't make
> > sense to bitwise match the recirc_id, so we didn't want to support it?
> 
> I think this is the case, and maybe it would be better to fix this by
> scan it without a mask and always return a full mask.

I think that's likely to have been the intent here, even if it was
buggy.

>   Jarno
> 
> 
> > Acked-by: Ben Pfaff <blp at nicira.com>
>