[ovs-dev] [PATCH 4/7] ofproto-dpif-xlate: Only generate recirculation flows when have a packet.

[Jarno Rajahalme]

> On Mar 3, 2015, at 10:09 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> On Tue, Feb 24, 2015 at 03:42:03PM -0800, Jarno Rajahalme wrote:
>> Traces should not modify the flow table without the a packet or
>> "-generate" option.
>> 
>> This patch also adds further testing to verify that MPLS recirculation
>> works.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> We also don't have a packet in the case of revalidation.  Does this do
> the right thing for revalidation?

No, thanks for pointing this out. I discussed this with Joe shortly and he noticed that we are not creating cache entries for these either, so in case full revalidation is not needed, the internal flow will time out after 60 seconds.

This patch makes it a worse by letting the internal flow time out even in case of full revalidation.

As this code is superseded by later patches in the series, I might just squash this in and essentially delete this patch, if the rest looks OK.

Thanks for the review,

  Jarno