[ovs-dev] [PATCH 00/32] Auto-Attach series plus refinements

Ben Pfaff blp at nicira.com
Wed Mar 4 00:39:51 UTC 2015


On Mon, Mar 02, 2015 at 04:00:17PM +0000, Flynn, Dennis R (Dennis) wrote:
> Hi Ben,
> 
> We have completed our testing with your additional refinements and everything looks good.
> 
> I have the following comments after reviewing your changes.
> Once these are addressed to your satisfaction we are good to go with committing these changes.
> 
> lib/lldp/lldp.c
> 
> 	- Remove lingering reference to POKE macro in comment
> 	- Should lldp_tlv_end() check for null after call to ofputbuf_at()?
> 	- lldp_send() - missing statement to set new h_lport.p_lastframe
> 
> Update Copyright statements adding '2015' in the following
> 
> 	- aa-structs.h
> 	- lib/lldp/lldp.c
> 	- lib/lldp/lldpd-structs.c
> 	- lib/lldp/lldpd.c
> 	- lib/lldp/lldpd.h
> 	- lib/ovs-lldpd.c  (Windriver)

Thanks for the review.  I fixed up lldp.c, updated copyright notices,
and applied this to master.



More information about the dev mailing list