[ovs-dev] [ovsdb-idlc 3/4] ovsdb-idlc: Add comments for remaining non-static functions.
Justin Pettit
jpettit at nicira.com
Wed Mar 4 23:50:06 UTC 2015
On Wed, Mar 4, 2015 at 1:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Mar 04, 2015 at 11:25:52AM -0800, Justin Pettit wrote:
> > Signed-off-by: Justin Pettit <jpettit at nicira.com>
>
> This comment might be even better if it made it clearer how
> transactions work. Maybe "The caller must have started a transaction
> with ovsdb_idl_txn_create()." I see that you used the same wording
> elsewhere too:
>
Good suggestion. I changed it in both locations.
Here, s/generate/generated/:
>
Fixed.
Acked-by: Ben Pfaff <blp at nicira.com>
>
Thanks! I'll push this soon.
--Justin
More information about the dev
mailing list