[ovs-dev] [PATCHv2 ovsdb-idlc] ovsdb-idlc: Generate comments for "*_set_*" functions.

[Justin Pettit]

On Mar 4, 2015, at 10:36 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> Some of the comment wording is odd, e.g. on
> ovsrec_autoattach_set_mappings():
> 
> * The value must be key in range 0 to 16,777,215, value in range 0 to 4,095.
> 
> or on ovsrec_bridge_set_flow_tables():
> 
> * The value must be key in range 0 to 254.

I had spot checked some of the constraints, but didn't notice those ones.  I've changed it now to "Argument constraints:", so those would now read:

 * Argument constraints: key in range 0 to 16,777,215, value in range 0 to 4,095
 * Argument constraints: key in range 0 to 254

Not perfect, but a bit clearer.

> That's all I noticed.  Seems like a nice improvement!
> 
> Acked-by: Ben Pfaff <blp at nicira.com>

Thanks for the feedback; the additional information is a big improvement.  I'll push it in a minute.

--Justin