[ovs-dev] [PATCH] bashcomp: Install and package completion scripts.

Alex Wang alexw at nicira.com
Thu Mar 12 23:37:32 UTC 2015


Yeah, the reason I did it this way is in that the ovs-vsctl-bashcomp.bash
script changes the $COMP_WORDBREAKS variable:
"""
export COMP_WORDBREAKS=" "
"""

This global variable contains the delimiter used by the bash completion for
breaking the arguments.  I'm a bit worried that this could cause the
malfunctioning of other completion modules/scripts.

Thanks,
Alex Wang,

On Thu, Mar 12, 2015 at 3:55 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Thu, Mar 12, 2015 at 03:34:48PM -0700, Alex Wang wrote:
> > This commit adds the bash completion scripts to scripts_SCRIPTS target
> > and makes sure they are packaged correctly.  Note, the scripts will only
> > be placed at the directory for scripts so that users can get them if
> needed.
> >
> > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> I know that Debian, at least, automatically loads completion scripts
> placed in /etc/bash_completion.d.  It can also autoload completion
> scripts when their commands are first used (and this is preferred) if
> you put a script (or a link to it) with the name of the command in
> /usr/share/bash-completion/completions/.  It would be nice if we
> packaged it up this way so that users get the benefits without having
> to take extra steps.
>



More information about the dev mailing list