[ovs-dev] [PATCH 3/3] command-line: add ovs_cmdl_context

[Ben Pfaff]

On Tue, Mar 17, 2015 at 10:14:59AM -0400, Russell Bryant wrote:
> On 03/16/2015 05:16 PM, Russell Bryant wrote:
> > On 03/16/2015 05:08 PM, Ben Pfaff wrote:
> >> Would you mind fixing that up?
> > 
> > No problem at all.  Thanks for the feedback!  I'll also start testing
> > builds with both gcc and clang, instead of just gcc.  I wonder how I
> > missed the error ... I'll get it fixed up in any case.
> 
> To get a clean build of master with clang, I needed to use the following:
> 
> CFLAGS="-Werror -Qunused-arguments -Wno-unused-value
> -Wno-tautological-compare"
> 
> Does that match your dev environment?

Without applying this patch to master, I don't have to use any special
flags to get a clean warning-free build.  I use:

    blp at sigabrt:~/nicira/ovs(0)$ clang --version
    Debian clang version 3.5.0-6 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
    Target: i386-pc-linux-gnu
    Thread model: posix

I don't have DPDK installed if that makes a difference.  I configure
with --enable-Werror.

I'd like to get to the bottom of why you're seeing something different;
my guess is a difference in Clang versions, since Clang pretty regularly
improves its warnings.