[ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

[Ben Pfaff]

On Thu, Mar 19, 2015 at 08:35:14AM +0900, Simon Horman wrote:
> On Tue, Mar 17, 2015 at 03:25:36PM -0700, Ben Pfaff wrote:
> > On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote:
> > I think that the documentation should mention that these new features
> > are only available in OVS 2.4 and up and only with OpenFlow 1.5 and
> > up and use a Netronome extension to OpenFlow.
> 
> Sure, how about the following squashed into this patch?

That's great, thank you!

> > In parse_ofp_group_mod_str__(), I think that '0' here should be either
> > 0 or '\0':
> > +            memset(gm->props.selection_method, '0',
> > +                   NTR_MAX_SELECTION_METHOD_LEN);
> 
> Thanks, I will go and find a brown paper bag.

Haha.  At any rate it did serve the purpose of clearing out any
uninitialized bytes ;-)