[ovs-dev] [PATCH 2/2] bashcomp: Install and package completion scripts.

Alex Wang alexw at nicira.com
Fri Mar 20 00:49:55 UTC 2015


On Thu, Mar 19, 2015 at 5:08 PM, Peter Amidon <peter at picnicpark.org> wrote:

> On Wed, 18 Mar 2015 14:47:25 -0700: Alex Wang <alexw at nicira.com> wrote:
>
>
>   > This commit makes the bash completion scripts be installed to
>   > /etc/bash_completion.d through 'make install' or package installation.
>   > This will make the scripts available for each bash session.
>
>   > An alternative is to put scripts to /usr/share/bash_completion/
> directory.
>   > However, this is not supported by earlier version of bash completion.
>
>   > Signed-off-by: Alex Wang <alexw at nicira.com>
>
> These changes look good to me overall, but I just realized that
> utilities/ovs-command-bashcomp.INSTALL.md still talks about how to
> manually install the scripts into /etc/bash_completion.d.  Should we
> also change it to make it clear that the scripts will be installed by
> default, with an explanation of how to manually use them in other cases?
>
>
Yeah, thx for pointing it out! I'll do that,

Are you okay with the patch 1/2?




> Thanks,
>
> Peter Amidon
>



More information about the dev mailing list