[ovs-dev] [PATCH] netdev-linux: Fix build with old kernel headers.

Ben Pfaff blp at nicira.com
Tue Mar 24 21:08:38 UTC 2015


On Tue, Mar 24, 2015 at 2:06 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Tue, Mar 24, 2015 at 12:51 PM, Ben Pfaff <blp at nicira.com> wrote:
>> Commit 677d9158fc0a (netdev-linux: Support for SFQ, FQ_CoDel and CoDel
>> qdiscs.) added support for new qdiscs.  The commit uses TCA_CODEL_* and
>> TCA_FQ_CODEL_* not in old kernel headers, causing a build failure against
>> such headers.  This commit should fix the problem by defining these values
>> ourselves.  (I haven't tested it against old headers, so I might have
>> missed something, but it's a straightforward change and at worst won't do
>> harm.)
>>
>> It appears that sfq (also added by the same commit) was in Linux before
>> 2.6.32, so it seems unlikely that we need any compatibility code there.
>>
>> CC: Jonathan Vestin <jonavest at kau.se>
>> Signed-off-by: Ben Pfaff <blp at nicira.com>
>
> Acked-by: Jesse Gross <jesse at nicira.com>

Thanks for the review, and sorry to have missed seeing your ack before
I applied the patch to master.

-- 
"I don't normally do acked-by's.  I think it's my way of avoiding
getting blamed when it all blows up."               Andrew Morton



More information about the dev mailing list