[ovs-dev] [PATCH 1/2] ovs-sandbox: Initialize database before starting ovs-vswitchd.

Ben Pfaff blp at nicira.com
Fri Mar 27 15:57:25 UTC 2015


On Thu, Mar 26, 2015 at 08:04:54PM -0400, Russell Bryant wrote:
> On 03/26/2015 01:25 AM, Ben Pfaff wrote:
> > Otherwise ovs-vswitchd can't immediately start working (until some other
> > call to ovs-vsctl initializes the database).  This is most obvious if one
> > runs "ovs-vsctl list Open_vSwitch ." as the first command, because the
> > output will not show the changes that ovs-vswitchd will make to the
> > database at startup (in particular initializing datapath_types and
> > iface_types), which is confusing.
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> Acked-by: Russell Bryant <rbryant at redhat.com>
> 
> The changes look correct to me.

Thanks, applied to master.

> On a related note, I didn't add "init" to ovn-nbctl.  It didn't seem to
> matter, but then again, no daemon was trying to use it since we don't
> have ovn-nbd yet.  So, perhaps it's needed there too?

"init" exists in ovs-vsctl because the OVS database needs to have one
record in a particular table (the Open_vSwitch table) to really be
usable.  "init" just makes sure that that record exists and, if not,
adds it.  I don't think the OVN databases have such a requirement yet,
but if they do (now or later) then we could add an "init" command.



More information about the dev mailing list