[ovs-dev] [PATCH] ofproto-dpif: Set need_revalidate when removing cfm from ofport.

Alex Wang alexw at nicira.com
Sat Mar 28 21:30:58 UTC 2015


Thx for the review! applied to master and branch-2.3~

On Sat, Mar 28, 2015 at 1:25 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Sat, Mar 28, 2015 at 11:12:12AM -0700, Alex Wang wrote:
> > >
> > > I think that the new version will force a reconfiguration for
> > > set_cfm(ofport, NULL) even if 'ofport' didn't have any CFM configured.
> > > That seems wrong to me.
> > >
> >
> > Thanks, this is a very good point, I think we should do it the same way
> as
> > set_bfd(), where we compare the old pointer and the new one, set the
> > need_revalidate when they are different,
> >
> > So, how about this~?
>
> That's good, thanks.
>
> Acked-by: Ben Pfaff <blp at nicira.com>
>



More information about the dev mailing list