[ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

Ben Pfaff blp at nicira.com
Tue Mar 31 15:31:24 UTC 2015


The description was at best incomplete and difficult to understand.

Reported-by: Brian Field <Brian_Field at cable.comcast.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
v1->v2: Fix reporter.

 AUTHORS              |  1 +
 vswitchd/vswitch.xml | 52 ++++++++++++++++++++++++++++++++++++++++------------
 2 files changed, 41 insertions(+), 12 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index 8fba915..1d2201c 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -216,6 +216,7 @@ Brad Hall               brad at nicira.com
 Brandon Heller          brandonh at stanford.edu
 Brendan Kelley          bkelley at nicira.com
 Brent Salisbury         brent.salisbury at gmail.com
+Brian Field             Brian_Field at cable.comcast.com
 Bryan Fulton            bryan at nicira.com
 Bryan Osoro             bosoro at nicira.com
 Cedric Hobbs            cedric at nicira.com
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 81e8b3f..e8fc271 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -980,18 +980,46 @@
 
       <column name="other_config" key="forward-bpdu"
               type='{"type": "boolean"}'>
-        Option to allow forwarding of BPDU frames when NORMAL action is
-        invoked.  Frames with reserved Ethernet addresses (e.g. STP
-        BPDU) will be forwarded when this option is enabled and the
-        switch is not providing that functionality.  If STP is enabled
-        on the port, STP BPDUs will never be forwarded.  If the Open
-        vSwitch bridge is used to connect different Ethernet networks,
-        and if Open vSwitch node does not run STP, then this option
-        should be enabled.  Default is disabled, set to
-        <code>true</code> to enable.
-
-        The following destination MAC addresss will not be forwarded when this
-        option is enabled.
+
+	<p>
+          Controls forwarding of BPDU frames when NORMAL action is invoked.
+          When this option is <code>false</code> or unset, frames with reserved
+          Ethernet addresses (see table below) will not be forwarded.  When
+          this option is <code>true</code>, such frames will not be treated
+          specially.
+	</p>
+
+	<p>
+	  The above general rule has the following exceptions:
+	</p>
+
+	<ul>
+	  <li>
+	    If STP is enabled on the bridge (see the <ref column="stp_enable"
+	    table="Open_vSwitch"/> column in the <ref table="Bridge"/> table),
+	    the bridge processes all received STP packets and never passes them
+	    to OpenFlow or forwards them.  This is true even if STP is disabled
+	    on an individual port.
+	  </li>
+
+	  <li>
+	    If LLDP is enabled on an interface (see the <ref column="lldp"
+	    table="Interface"/> column in the <ref table="Interface"/> table),
+	    the interface processes received LLDP packets and never passes them
+	    to OpenFlow or forwards them.
+	  </li>
+	</ul>
+
+	<p>
+	  Set this option to <code>true</code> if the Open vSwitch bridge
+	  connects different Ethernet networks and does not run STP.
+	</p>
+
+        <p>
+	  This option affects packets with the following destination MAC
+	  addresses:
+	</p>
+
         <dl>
           <dt><code>01:80:c2:00:00:00</code></dt>
           <dd>IEEE 802.1D Spanning Tree Protocol (STP).</dd>
-- 
2.1.3




More information about the dev mailing list