[ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

Justin Pettit jpettit at nicira.com
Tue Mar 31 17:14:55 UTC 2015


> On Mar 31, 2015, at 8:31 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> +	    If STP is enabled on the bridge (see the <ref column="stp_enable"
> +	    table="Open_vSwitch"/> column in the <ref table="Bridge"/> table),

I think that should be "Bridge" instead of "Open_vSwitch".

> +	  Set this option to <code>true</code> if the Open vSwitch bridge
> +	  connects different Ethernet networks and does not run STP.

This reads ambiguous to me whether the bridge or network is not running STP.  How about something like the following?

    Set this option to <code>true</code> if the Open vSwitch bridge
    connects different Ethernet networks and is not configured to
    participate in STP.

I'd like to hear from Brian, but it looks like an improvement to me:

Acked-by: Justin Pettit <jpettit at nicira.com>

--Justin





More information about the dev mailing list