[ovs-dev] [PATCH net] openvswitch: Return vport module ref before destruction

[David Miller]

From: Thomas Graf <tgraf at suug.ch>
Date: Mon, 30 Mar 2015 13:57:41 +0200

> Return module reference before invoking the respective vport
> ->destroy() function. This is needed as ovs_vport_del() is not
> invoked inside an RCU read side critical section so the kfree
> can occur immediately before returning to ovs_vport_del().
> 
> Returning the module reference before ->destroy() is safe because
> the module unregistration is blocked on ovs_lock which we hold
> while destroying the datapath.
> 
> Fixes: 62b9c8d0372d ("ovs: Turn vports with dependencies into separate modules")
> Reported-by: Pravin Shelar <pshelar at nicira.com>
> Signed-off-by: Thomas Graf <tgraf at suug.ch>
> ---
> @Dave: Please also queue for 3.19.x stable series

Applied and queued up for -stable, thanks Thomas.