[ovs-dev] REMINDER: [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

Ben Pfaff blp at nicira.com
Tue Mar 31 23:54:08 UTC 2015


On Sat, Mar 21, 2015 at 03:18:39PM +0530, Rishi Bamba wrote:
> Hope you are doing fine.
> We are awaiting response from you & the OVS Team regarding the patch "ovs-ofctl: Implementation of eviction on the basis of Importance" which is already under review.
> The last revised patch was sent on 11.02.2015 as per the comments received from you.

The code still has problems even after multiple rounds of review.

Even after I asked specifically about it, you still have not fixed
issues with indentation.

You don't version your patches and describe what has changed from one
version to another, like everyone else.

You don't bother to read and follow CodingStyle.md.

You write code that contains cut-and-paste duplication.

Fix all of that and I'll take another look.



More information about the dev mailing list