[ovs-dev] [PATCH] odp-util: Fix a bug in parse_flag().

Alex Wang alexw at nicira.com
Sat May 2 18:21:13 UTC 2015


Thx for pointing me to the example~

After check the tests, want to ask what is the difference between masked
flag and unmasked flag?  especially for tunnel,

Thanks,
Alex Wang,

On Sat, May 2, 2015 at 10:55 AM, Ben Pfaff <blp at nicira.com> wrote:

> Can we just add an example to tests/odp.at?
>
> On Sat, May 02, 2015 at 10:51:30AM -0700, Alex Wang wrote:
> > Thx, I'll apply this first, trying to think of a good way to test it~
> >
> > On Sat, May 2, 2015 at 10:13 AM, Ben Pfaff <blp at nicira.com> wrote:
> >
> > > On Fri, May 01, 2015 at 08:58:57PM -0700, Alex Wang wrote:
> > > > This commit fixes a bug in the parse_flag() function which causes
> > > > failure of parsing tunnel flags like:
> > > >
> > > >
> > >
> tunnel(tun_id=0x0,src=1.2.3.4,dst=1.2.3.5,tos=0,ttl=64,flags(-df+csum+key))
> > > >
> > > > Reported-by: Jacob Cherkas <jcherkas at nicira.com>
> > > > Signed-off-by: Alex Wang <alexw at nicira.com>
> > >
> > > Fantastic, thank you--I noticed the same problem a few days ago testing
> > > OVN but hadn't had time to follow up yet.
> > >
> > > Can you add a test?
> > >
> > > Thanks,
> > >
> > > Ben.
> > >
>



More information about the dev mailing list