[ovs-dev] [PATCH] ARP lookup and next hop functionality on windows

[Ben Pfaff]

On Mon, May 04, 2015 at 03:34:58PM +0000, Alin Serdean wrote:
> This patch implements two functionalities needed for an active manager:
> 1. ARP lookup
> 2. Next hop
> 
> The first functionality relies on the internal Windows API:
> https://msdn.microsoft.com/en-us/library/windows/desktop/aa365956%28v=vs.85%29.aspx
> 
> The second one:
> https://msdn.microsoft.com/en-us/library/windows/desktop/aa365915%28v=vs.85%29.aspx
> 
> Both API's are found in the Iphlpapi library. We need to add this library
> when compiling.
> 
> Documentation and appveyor config has been updated to match the use of
> the new library.
> 
> Tested using opendaylight.
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> Reported-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/63

Hi Alin, thanks for the patch.  I have a few comments, though this
can't be considered a real review.

In netdev_windows_arp_lookup(), I noticed that GetIpNetTable is
documented to output, on error, the required buffer size.  Would it
make sense to take advantage of that instead of doubling?

The same appears to be true for GetAdaptersAddresses().

I see that VLOG calls that print an error only give the error number.
It would be more user friendly to translate this to an error name.

Thanks,

Ben.