[ovs-dev] [PATCH] datapath: Fix Sparse warning.

[Pravin Shelar]

On Fri, May 15, 2015 at 5:48 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Fri, May 15, 2015 at 5:05 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> CHECK   /home/pravin/ovs/w8/datapath/linux/flow_table.c
>> /home/pravin/ovs/w8/datapath/linux/flow_table.c:536:6: warning: symbol
>> 'ovs_flow_cmp_unmasked_key' was not declared. Should it be static?
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> Acked-by: Jesse Gross <jesse at nicira.com>
>
Pushed patch to master. Thanks.

> I noticed two others though (in addition to the old SCTP ones):
>   CHECK   /home/jesse/openvswitch/datapath/linux/datapath.c
> /home/jesse/openvswitch/datapath/linux/datapath.c:1523:28: warning:
> symbol 'i' shadows an earlier one
> /home/jesse/openvswitch/datapath/linux/datapath.c:1501:18: originally
> declared here
>
I have seen this. I am planning on sending fix upstream.

>   CHECK   /home/jesse/openvswitch/datapath/linux/gso.c
> /home/jesse/openvswitch/datapath/linux/gso.c:85:5: warning: symbol
> 'rpl_dev_queue_xmit' was not declared. Should it be static?

I did not noticed this one. I will send fix for it.